Skip to content

[CLEANUP] Avoid Hungarian notation for isForIdentifier #961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 20, 2025
Merged

[CLEANUP] Avoid Hungarian notation for isForIdentifier #961

merged 1 commit into from
Feb 20, 2025

Conversation

@oliverklee
Copy link
Collaborator

@oliverklee oliverklee commented Feb 20, 2025

Part of #756

@oliverklee oliverklee requested a review from JakeQZ February 20, 2025 08:40
@oliverklee oliverklee self-assigned this Feb 20, 2025
@coveralls
Copy link

coveralls commented Feb 20, 2025 •
edited
Loading

Coverage Status

coverage: 51.654%. remained the same
when pulling ffa88c2 on cleanup/hungarian/is-for-identifier
into d6088b2 on main.

@oliverklee oliverklee force-pushed the cleanup/hungarian/is-for-identifier branch from 808d20b to ffa88c2 Compare February 20, 2025 10:03
@JakeQZ JakeQZ merged commit 3a05e1f into main Feb 20, 2025
21 checks passed
@JakeQZ JakeQZ deleted the cleanup/hungarian/is-for-identifier branch February 20, 2025 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JakeQZ JakeQZ JakeQZ approved these changes

Assignees

@oliverklee oliverklee

Labels

cleanup

Projects

None yet

Milestone

9.0.0: Drop support for PHP < 7.2 and...

Development

Successfully merging this pull request may close these issues.

4 participants

@oliverklee @coveralls @JakeQZ